Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/1.8.0: document environment naming conventions #1300

Merged
merged 6 commits into from
Sep 17, 2024
Merged

release/1.8.0: document environment naming conventions #1300

merged 6 commits into from
Sep 17, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 16, 2024 •
edited
Loading

Summary

Resolves #1291 by adding a table to doc/source/PreConfiguredSites.rst.

Testing

Readthedocs build: https://spack-stack--1300.org.readthedocs.build/en/1300/PreConfiguredSites.html

Applications affected

None

Systems affected

None

Dependencies

None

Issue(s) addressed

Resolves #1291

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji force-pushed the feature/rel180_doc_env_name_conventions branch from 12a9a0d to a12af63 Compare September 16, 2024 20:28
@climbfuji climbfuji force-pushed the feature/rel180_doc_env_name_conventions branch 2 times, most recently from 71a5523 to 0578854 Compare September 16, 2024 23:24
@climbfuji climbfuji force-pushed the feature/rel180_doc_env_name_conventions branch from 0578854 to 28442ba Compare September 16, 2024 23:27
@srherbener
Copy link
Collaborator

@climbfuji is this PR supposed to be based on release/1.8.0 instead of develop?

@climbfuji climbfuji changed the base branch from develop to release/1.8.0 September 16, 2024 23:49
@climbfuji
Copy link
Collaborator Author

@climbfuji is this PR supposed to be based on release/1.8.0 instead of develop?

Yes :-) and now it is. Thanks for catching this!

AlexanderRichert-NOAA
AlexanderRichert-NOAA reviewed Sep 17, 2024
View reviewed changes
configs/sites/tier1/jet/mirrors.yaml Outdated
access_pair:
- null
- null
access_token: null
profile: null
endpoint_url: null
push:
url: file:///mnt/lfs4/HFIP/hfv3gfs/role.epic/spack-stack/source-cache
url: file:///contrib/spack-stack/mirror
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that space on /contrib is a bit more precious than lfs. Not that we're not allowed to put caches there, but from a being-good-neighbors perspective we might want to consider leaving the caches on lfs, and just have the installations themselves under /contrib.

@AlexanderRichert-NOAA
Copy link
Collaborator

Documentation updates looks good, thanks for adding that!

@climbfuji
Copy link
Collaborator Author

The jet updates have nothing to do with this PR and should be removed ...

@RatkoVasic-NOAA
Copy link
Collaborator

The jet updates have nothing to do with this PR and should be removed ...
@climbfuji , sorry, I saw other than document files in this PR. Reverted.

RatkoVasic-NOAA
RatkoVasic-NOAA approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed this convention on tier1 machines. Looks good.

@climbfuji
Copy link
Collaborator Author

The jet updates have nothing to do with this PR and should be removed ...
@climbfuji , sorry, I saw other than document files in this PR. Reverted.

Yeah, apologies. This PR originally had develop as the target/base branch and showed all the changes between (release/1.8.0 plus this PR) and develop. Steve pointed that out and I changed the base branch to release/1.8.0. Let's do all the NOAA site config and doc updates in a separate PR from you, ok?

@climbfuji climbfuji merged commit 2d3a1f8 into JCSDA:release/1.8.0 Sep 17, 2024
7 of 8 checks passed
@climbfuji climbfuji deleted the feature/rel180_doc_env_name_conventions branch September 17, 2024 02:12
@climbfuji climbfuji mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA left review comments

@RatkoVasic-NOAA RatkoVasic-NOAA RatkoVasic-NOAA approved these changes

@srherbener srherbener Awaiting requested review from srherbener

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standard naming convention for each environment
4 participants
@climbfuji @srherbener @AlexanderRichert-NOAA @RatkoVasic-NOAA